Memoize @exercise_params

2021-10-08 09:26:39 +02:00
parent 6321b2edef
commit ccf2f1f5fd
1 changed files with 23 additions and 5 deletions
--- a/app/controllers/exercises_controller.rb
+++ b/app/controllers/exercises_controller.rb
@ -201,11 +201,29 @@ raise: false
  private :user_by_codeharbor_token

  def exercise_params
-    if params[:exercise].present?
-      params[:exercise].permit(:description, :execution_environment_id, :file_id, :instructions, :submission_deadline, :late_submission_deadline, :public, :unpublished, :hide_file_tree, :allow_file_creation, :allow_auto_completion, :title, :expected_difficulty, :tips, files_attributes: file_attributes, tag_ids: []).merge(
-        user_id: current_user.id, user_type: current_user.class.name
-      )
-    end
+    @exercise_params ||= if params[:exercise].present?
+                           params[:exercise].permit(
+                             :description,
+                             :execution_environment_id,
+                             :file_id,
+                             :instructions,
+                             :submission_deadline,
+                             :late_submission_deadline,
+                             :public,
+                             :unpublished,
+                             :hide_file_tree,
+                             :allow_file_creation,
+                             :allow_auto_completion,
+                             :title,
+                             :expected_difficulty,
+                             :tips,
+                             files_attributes: file_attributes,
+                             tag_ids: []
+                           ).merge(
+                             user_id: current_user.id,
+                             user_type: current_user.class.name
+                           )
+                         end
  end
  private :exercise_params