Fix Rubocop offenses
This commit is contained in:
@ -118,7 +118,7 @@ describe Runner::Strategy::Poseidon do
|
||||
let(:response_status) { -1 }
|
||||
|
||||
it 'raises an error' do
|
||||
faraday_connection = instance_double 'Faraday::Connection'
|
||||
faraday_connection = instance_double Faraday::Connection
|
||||
allow(described_class).to receive(:http_connection).and_return(faraday_connection)
|
||||
%i[post patch delete].each {|message| allow(faraday_connection).to receive(message).and_raise(Faraday::TimeoutError) }
|
||||
expect { action.call }.to raise_error(Runner::Error::FaradayError)
|
||||
@ -131,7 +131,7 @@ describe Runner::Strategy::Poseidon do
|
||||
let(:execution_environment) { create(:ruby) }
|
||||
|
||||
it 'makes the correct request to Poseidon' do
|
||||
faraday_connection = instance_double 'Faraday::Connection'
|
||||
faraday_connection = instance_double Faraday::Connection
|
||||
allow(described_class).to receive(:http_connection).and_return(faraday_connection)
|
||||
allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status: 201))
|
||||
action.call
|
||||
@ -143,7 +143,7 @@ describe Runner::Strategy::Poseidon do
|
||||
|
||||
shared_examples 'returns true when the api request was successful' do |status|
|
||||
it "returns true on status #{status}" do
|
||||
faraday_connection = instance_double 'Faraday::Connection'
|
||||
faraday_connection = instance_double Faraday::Connection
|
||||
allow(described_class).to receive(:http_connection).and_return(faraday_connection)
|
||||
allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status: status))
|
||||
expect(action.call).to be_truthy
|
||||
@ -152,7 +152,7 @@ describe Runner::Strategy::Poseidon do
|
||||
|
||||
shared_examples 'returns false when the api request failed' do |status|
|
||||
it "raises an exception on status #{status}" do
|
||||
faraday_connection = instance_double 'Faraday::Connection'
|
||||
faraday_connection = instance_double Faraday::Connection
|
||||
allow(described_class).to receive(:http_connection).and_return(faraday_connection)
|
||||
allow(faraday_connection).to receive(:put).and_return(Faraday::Response.new(status: status))
|
||||
expect { action.call }.to raise_exception Runner::Error::UnexpectedResponse
|
||||
@ -168,7 +168,7 @@ describe Runner::Strategy::Poseidon do
|
||||
end
|
||||
|
||||
it 'raises an exception if Faraday raises an error' do
|
||||
faraday_connection = instance_double 'Faraday::Connection'
|
||||
faraday_connection = instance_double Faraday::Connection
|
||||
allow(described_class).to receive(:http_connection).and_return(faraday_connection)
|
||||
allow(faraday_connection).to receive(:put).and_raise(Faraday::TimeoutError)
|
||||
expect { action.call }.to raise_exception Runner::Error::FaradayError
|
||||
|
Reference in New Issue
Block a user