htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #186 from openHPI/fix/exercise-anomaly-detection-nil-values

Browse Source 
Reject nil values in working times
This commit is contained in:
rteusner
2018-07-13 23:23:35 +02:00
committed by GitHub
parent 946e8e2f13 815d700481
commit eed28be33d
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/tasks/detect_exercise_anomalies.rake
View File

@ -71,10 +71,9 @@ namespace :detect_exercise_anomalies do
end end
def find_anomalies(collection) def find_anomalies(collection)
working_times = collect_working_times(collection) working_times = collect_working_times(collection).reject {|_, value| value.nil?}
values = working_times.values.reject {|value| value.nil?} if working_times.size > 0
if values.size > 0 average = working_times.reduce(:+) / working_times.size
average = values.reduce(:+) / values.size
return working_times.select do |_, working_time| return working_times.select do |_, working_time|
working_time > average * MAX_TIME_FACTOR or working_time < average * MIN_TIME_FACTOR working_time > average * MAX_TIME_FACTOR or working_time < average * MIN_TIME_FACTOR
end end