htwkmooc/codeocean
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow fa-spin to spin, actually

Browse Source 
When using `display: inline;`, many browsers won't rotate the icon.
This commit is contained in:
Sebastian Serth
2022-08-12 18:01:47 +02:00
parent cc7a1d7fb5
commit f38052d235
3 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/editor/editor.js.erb
View File

@ -217,7 +217,7 @@ var CodeOceanEditor = {
hideSpinner: function () { hideSpinner: function () {
$('button i.fa-solid, button i.fa-regular').show(); $('button i.fa-solid, button i.fa-regular').show();
$('button i.fa-spin').hide(); $('button i.fa-spin').removeClass('d-inline-block').addClass('d-none');
}, },
@ -704,7 +704,7 @@ var CodeOceanEditor = {
showSpinner: function (initiator) { showSpinner: function (initiator) {
$(initiator).find('i.fa-solid, i.fa-regular').hide(); $(initiator).find('i.fa-solid, i.fa-regular').hide();
$(initiator).find('i.fa-spin').show(); $(initiator).find('i.fa-spin').addClass('d-inline-block').removeClass('d-none');
}, },
showStatus: function (output) { showStatus: function (output) {

4
app/assets/stylesheets/editor.css.scss
View File

@ -1,7 +1,3 @@
button i.fa-spin {
display: none;
}
.editor { .editor {
height: 100%; height: 100%;
width: 100%; width: 100%;

2
app/views/exercises/_editor_button.html.slim
View File

@ -1,4 +1,4 @@
button.btn class=local_assigns.fetch(:classes, 'btn-primary') *local_assigns.fetch(:data, {}) disabled=local_assigns.fetch(:disabled, false) id=id title=local_assigns[:title] type='button' button.btn class=local_assigns.fetch(:classes, 'btn-primary') *local_assigns.fetch(:data, {}) disabled=local_assigns.fetch(:disabled, false) id=id title=local_assigns[:title] type='button'
i.fa-solid.fa-circle-notch.fa-spin class=(label.blank? ? "m-0" : '') i.fa-solid.fa-circle-notch.fa-spin.d-none class=(label.blank? ? "m-0" : '')
i class=(label.present? ? icon : "#{icon} m-0") i class=(label.present? ? icon : "#{icon} m-0")
= label = label