Commit Graph

62 Commits

Author SHA1 Message Date
baa0784ede Add custom_embed_option to disallow downloading submissions 2019-03-29 14:56:14 +01:00
6e03939c10 Add StudyGroup to submissions and show it for submissions and RfCs
Also take care of deleting a StudyGroup for existing submissions
2019-03-06 14:00:58 +01:00
9087d42088 Fix usage of incorrect downcase method 2018-12-19 19:47:16 +01:00
ac7e41d8b3 Merge pull request #248 from openHPI/improve_groups
Improve groups with a view and always create a group
2018-12-19 13:57:41 +01:00
d95cf1cffb Merge branch 'master' into add_roles_via_LTI
# Conflicts:
#	app/controllers/concerns/lti.rb
2018-12-19 01:44:34 +01:00
c0608b6f50 Don't set admin privileges through LTI 2018-12-19 01:43:37 +01:00
7dc83065eb Create study groups for every LTI launch 2018-12-14 15:11:50 +01:00
2c29bf4e2b Merge branch 'master' into add_groups 2018-12-14 00:57:26 +01:00
1a26d67c82 Merge branch 'master' into add_roles_via_LTI
# Conflicts:
#	app/views/application/_breadcrumbs.html.slim
#	app/views/application/welcome.html.slim
#	app/views/exercise_collections/show.html.slim
#	app/views/external_users/index.html.slim
#	app/views/layouts/application.html.slim
#	app/views/proxy_exercises/index.html.slim
#	app/views/user_exercise_feedbacks/index.html.slim
#	app/views/user_mailer/send_thank_you_note.slim
2018-12-14 00:53:06 +01:00
3665058435 Fix tests and slightly refactor some policies 2018-12-12 14:09:20 +01:00
71fd3b9b07 Add role to ExternalUser and update it via LTI 2018-12-12 14:09:19 +01:00
b137e64020 Add StudyGroups with ExternalUsers only 2018-12-12 12:09:52 +01:00
a0d8b30ef2 Implement support for some basic embed options for work sheets via LTI
This commit also fixes an issue with the flash messages being positioned too high and displayed for too long
2018-12-11 14:29:36 +01:00
1bed13d941 Remove useless .keep files 2018-11-06 16:49:41 +01:00
de52db89f0 Upgrade Rails to version 5.2.1 and adopt code & specs where necessary
Signed-off-by: Sebastian Serth <Sebastian.Serth@student.hpi.de>
2018-11-06 16:46:00 +01:00
841a885711 Send hints when scoring 2018-03-13 14:52:40 +01:00
c70fbce933 Merge branch 'master' into fix-structured-errors-2 2018-01-31 15:21:48 +01:00
efc271c4ed add column full_score_reached, fill it accordingly and show information in the rfc index 2018-01-31 11:23:30 +01:00
32c274d455 Rename attribute and restructure conditions 2017-11-29 10:39:05 +01:00
9bebbe9a6c Merge remote-tracking branch 'origin/master' into error-info
# Conflicts:
#	app/controllers/concerns/submission_scoring.rb
#	app/views/application/_navigation.html.slim
#	config/locales/de.yml
#	config/locales/en.yml
#	db/schema.rb
2017-10-15 17:02:19 +02:00
e52c9213a1 try to activate interpretation of carriage return 2017-10-04 16:42:42 +02:00
b078cddc68 enhance testrun output 2017-10-04 16:18:24 +02:00
194984a620 add cause to testruns
trigger run and assess on request_for_comment
2017-09-21 17:21:10 +02:00
8d1c846fae changes to newrelic 2017-09-20 13:29:26 +02:00
0f65508951 Merge pull request #109 from openHPI/use_names_from_lti
restrict name to be set to lis_person_name_full (should be display na…
2017-08-28 16:25:26 +02:00
4d684a7a05 Extract structured errors on run and submit 2017-07-12 09:52:33 +02:00
5949d1208e Merge branch 'master' into client-routesv2 2017-04-25 13:50:08 +02:00
ce2823e871 restrict name to be set to lis_person_name_full (should be display name) or to lis_person_name_given (should be first name).
don't use xikolo api any longer for consumer openHPI, use the values in CodeOcean.
2017-04-03 15:26:02 +02:00
12adfde6c2 search bar now searches in forum of the course from where the LTI request came from. alternatively searches in the java 2017 course.
show interventions only in the current java course
2017-03-21 10:31:45 +01:00
1eea3fab4c lots of renaming to _ names instead of camelCase 2017-03-21 10:31:32 +01:00
d5b2ea4269 added proxy exercise dispatching to LTI module. Submissions now set user before the exercise token gets validated. this we need to set the exercise behind the proxy exercise 2017-03-21 10:31:32 +01:00
a52b27bb59 render html and or markdown for feedback messages 2017-02-08 16:19:41 +01:00
3562aa9103 create remote evaluation 2017-02-02 18:14:33 +01:00
4af24d4317 fixing tests p2 lti_spec tests all passed 2017-01-13 00:37:07 +01:00
5fe12bfa78 fixing tests p1 2017-01-12 18:12:36 +01:00
e4daa7ece3 only destroy LTI_parameter when exercise is submitted 2017-01-12 16:03:30 +01:00
dd4c789fed replaced session_paramerters with server params for security reasons
cleaned up comments
2017-01-12 15:10:34 +01:00
41a61a8507 Fixed the destroy session logic.
1. an exercise_id is provided ==> only the LtiParameter object for the current user, consumer, and exercise is deleted.
2. no exercise_id is provided ==> external user and consumer are removed from the session, all LtiParameter objects for this user and consumer are deleted.

This enables users to have several tabs with exercises open and submitting the results to the tool consumer.
When an exercise has been submitted, the user cannot use the back button to get back to CodeOcean and work on the submitted or any other exercise.
For now a warning has been added to the info text to tell users not to do this. (As the LtiParameters have been deleted, the points can no more be submitted to the consumer.)
@TODO disable/redirect back button?
2016-12-31 17:21:46 +01:00
edb813ab14 added separate value for the actual external_id of the external user. 2016-12-31 00:58:36 +01:00
f318c62818 session[:external_user_id] has a somewhat misleading name.
As the tests fail however, when the value that  fits the name is entered, I switched it back to the old version.
2016-12-31 00:51:07 +01:00
ca28e0aa87 updated rails from 4.1.13 to 4.2.5. This is required for rails to make use of new features in postgres 9.5
@Ralf
TODO: migration /Users/groucho/Documents/HPI/workspace/Xikolo-CodeOcean/codeocean/db/migrate/20160204111716_add_user_to_code_harbor_link.rb
is broken. A reference is made to table users which does not exist.
Workaround: run rake db:schema:load before running db:migrate. Still this should be fixed.
2016-12-31 00:05:23 +01:00
325ea25849 Replaced session[:lti_parameters] with proper LtiParameter object.
Removed all tests that would be failing

TODO: decision if all LtiParameter objects for a certain user/consumer will be deleted when the user/consumer is deleted from the session, or only the LtiParameter object for the current exercise of the user/consumer.

TODO: replace removed tests with proper tests
2016-12-30 09:45:39 +01:00
6f1d8b2d38 Marked more locations that might require to be changed when we switch from session to LtiParameters Object 2016-12-27 07:48:59 +01:00
f4c01879bf preparations to replace session with lti_parameters object 2016-12-27 00:13:41 +01:00
4f8feb38e1 Use file template to generate new file content 2016-06-10 13:41:38 +02:00
dcb05b9169 Fix testrun result for docker container depletion 2016-03-09 16:21:32 +01:00
087b2bdf93 Persist assessments in the testrun model 2016-03-09 14:49:44 +01:00
b417231c12 a more defensive version of scoring to please the tests.. 2015-08-26 11:51:33 +02:00
89683dab9d Try to fix bug 2015-04-28 17:11:06 +02:00
2480c51c2b Cleanup logs 2015-04-28 16:02:22 +02:00