a more defensive version of scoring to please the tests..

2015-08-26 11:51:33 +02:00
parent bc51948ada
commit b417231c12
1 changed files with 8 additions and 2 deletions
--- a/app/controllers/concerns/submission_scoring.rb
+++ b/app/controllers/concerns/submission_scoring.rb
@ -26,8 +26,14 @@ module SubmissionScoring

  def score_submission(submission)
    outputs = collect_test_results(submission)
-    score = outputs.map { |output|
-      output[:score] * output[:weight] }.reduce(:+)
+    score = 0.0
+    if not (outputs.nil? || outputs.empty?)
+      outputs.each do |output|
+        if not output.nil?
+          score += output[:score] * output[:weight]
+        end
+      end
+    end
    submission.update(score: score)
    outputs
  end