Maximilian Grundke
b5c997e8a9
Preprocess comment text to protect from XSS attacks
2017-08-16 18:20:56 +02:00
Maximilian Grundke
1ffda4f896
Fix cluster sorting
2017-08-16 17:29:26 +02:00
Maximilian Grundke
0f3db8a644
Remove old comments before refresh to fix event leak
2017-08-16 17:29:08 +02:00
Maximilian Grundke
520a60d1be
Use popovers with formatted comments instead of tooltips
2017-08-13 18:46:35 +02:00
Maximilian Grundke
ba8511fe40
Fall back on RFC update time when there are no comments
2017-08-13 16:09:15 +02:00
Maximilian Grundke
726ef31ee7
Add new route to view all RFCs the user has commented on
2017-08-13 15:01:11 +02:00
Maximilian Grundke
b2344cfd97
Add last activity label to RFCs
2017-08-13 14:33:12 +02:00
Ralf Teusner
9592b5c939
removed tabs from rfc comment overlays
...
fixed minor typo in thank you emails
2017-08-11 18:23:16 +02:00
Ralf Teusner
38c6e29cbf
remove webWorker outputs from request_for_comments
2017-07-19 14:29:45 +02:00
Maximilian Grundke
76f563016a
Hide button after rfc is solved and add check mark to title
2017-06-12 14:11:12 +02:00
Maximilian Grundke
e43b71bd7f
Allow to hide thank you note
2017-06-09 14:46:20 +02:00
Maximilian Grundke
e4d1f57164
Send optional thank you note
2017-06-08 16:46:44 +02:00
Maximilian Grundke
9a71405c49
Add thank you note frontend
2017-06-08 16:02:05 +02:00
Maximilian Grundke
bacbf05f59
Re-use button instead of hiding it. Clean up code.
2017-06-08 14:57:49 +02:00
Ralf Teusner
81e7cbc8be
clear comment modal if comment was created
2017-04-18 17:46:36 +02:00
Ralf Teusner
234c19ac6c
only format comments that do not include a tab or a carriage return.
2017-04-18 17:44:42 +02:00
Thomas Hille
60e587b690
removed comment on exercise in the RFC view. redirect 10% of user instead of redirecting to the RFC view to the feedback view. redirect all users how submitted to the feedback view if score is less than 100%
2017-04-12 11:47:39 +02:00
Ralf Teusner
4a8ed1d1fb
show comments with breaks after 80 chars and tab subsequent lines in.
2017-04-07 21:15:52 +02:00
Ralf Teusner
58f76f53e6
added a search for request_for_comments.
...
fixed translation of model for request_for_comments
2017-04-03 19:49:03 +02:00
Thomas Hille
af0cc8cdb0
changed button design
2017-03-30 22:10:02 +02:00
Thomas Hille
3f398c6047
add feedback for exercises
2017-03-30 22:06:17 +02:00
Ralf Teusner
8f927d5ac9
some howto text for request_for_comment usage, changed background color of read-only editor.
2017-03-15 16:15:29 +01:00
Ralf Teusner
802502935e
removed debug statement...
2016-12-20 16:08:08 +01:00
Ralf Teusner
1108f954ba
show admin menu on RFC page for admins
2016-12-19 18:30:39 +01:00
Ralf Teusner
6e6c9143cd
Some tidy up in request for comments (bugfix: removed leftover parts of requested_at attribute, some UI changes in comment dialog)
...
Redirect to open rfc if an exercise has been solved
2016-08-11 18:13:33 +02:00
Ralf Teusner
39a253997d
use submission from model
2016-07-14 16:59:42 +02:00
Ralf Teusner
8282820974
removed requested_at
...
partly using submission_id
some cleanup
2016-07-14 16:22:22 +02:00
Ralf Teusner
223df2ffa8
some cleanup of request for comments. Work in progress.
...
Noticed a flaw when fetching the last submission, which is caused by timezone differences. First step to solve this.
Existing Request for Comments still need to be updated with their current submissionId, the SQL to do that is not yet finished.
2016-07-04 17:44:22 +02:00
Ralf Teusner
2ff12dbeb6
Cached displaynames of users
...
Added solved state and #comments to index of request_for_comments
Added translations
2016-06-27 16:46:26 +02:00
Ralf Teusner
2a52b66daa
rfc can now be solved.
...
show.html still needs to be finished
2016-06-24 16:44:34 +02:00
Ralf Teusner
bd6d4c4d71
Syntax Highlighting for the Request for Comment View
2016-06-23 14:23:28 +02:00
Ralf Teusner
918da5270d
added id for h4 holding the rfc-id
...
updated locales.
2016-06-22 13:06:35 +02:00
Ralf Teusner
ec26a095f6
First working version of mails on comments.
2016-06-17 14:48:57 +02:00
Ralf Teusner
b6cd797772
Show displayname instead of username in request_for_comment
2016-05-31 11:17:11 +02:00
Maximilian Grundke
87d4eb8b0d
Let everyone see all comments and polish request for comments overview
2016-05-10 18:17:02 +02:00
Maximilian Grundke
6f3d26db06
Fix click event for compatibility (for example with Firefox)
2016-05-07 15:01:34 +02:00
Ralf Teusner
c9b2af0fdb
show question instead of execution environement
2016-05-06 17:24:38 +02:00
Maximilian Grundke
d2ebfc9fde
Fix no question label
2016-04-30 14:43:51 +02:00
Maximilian Grundke
268b723f3a
Fallback for no question asked
2016-04-30 14:02:49 +02:00
Maximilian Grundke
c4405e24b9
Show question in overview
2016-04-30 13:57:23 +02:00
Ralf Teusner
8ba67c68c0
retrieve correct displaynames for users (from consumer if it is openHPI, otherwise use internal name)
2016-04-27 18:33:27 +02:00
Maximilian Grundke
d56290f2d8
Remove constraints for click event
2016-04-27 18:02:50 +02:00
Maximilian Grundke
57b773698b
Fix comment policy
2016-04-26 17:42:53 +02:00
Maximilian Grundke
4b5cd5a22a
Use better modal
2016-04-26 16:06:32 +02:00
Maximilian Grundke
96c7e5958f
Make requests sortable
2016-04-26 14:22:57 +02:00
Maximilian Grundke
3f0edeadf1
Refactor request for comments view
2015-11-11 13:55:08 +01:00
Maximilian Grundke
be87f939c6
Add support for comments on multiple files per exercise
2015-11-07 15:57:32 +01:00
Ralf Teusner
d292fec47c
Code Cleanup: Usage of Polymorphic User instead of ExternalUser and InternalUser
...
Renamed requestor_user_id -> user_id
Index of request_for_comments now returns the n (5?) newest requests per user. Solved via sliding windows in postgres, code added to model.
Added route to /my_request_for_comments/ that shows all requests for the current user.
Changed view from ERB to slim
2015-09-04 14:05:30 +02:00
Ralf Teusner
e520914385
Some correction of column names.
...
Support for internal as well as external users. Added column user_type and used it where necessary
2015-08-18 17:44:31 +02:00
Ralf Teusner
512e90ebd7
Show correct usernames on comments, have correct linenumbers on request_for_comments
2015-08-18 16:32:56 +02:00