Commit Graph

412 Commits

Author SHA1 Message Date
Sebastian Serth
b6b75cee0e Improve SQL query for exercise statistics
Removing the call to distinct dramatically improves the page load time. I don't know why, but since we are only using the users to filter the submission, it's not harmful to omit it.
2023-05-12 07:52:56 +02:00
Sebastian Serth
83e7eb3ce6 Hide exercise statistics for empty user group
Fixes ODEOCEAN-M5
2023-04-14 14:27:27 +02:00
Sebastian Serth
d90cdcf80e Enlarge Run and Stop buttons again
After the recent change where we wrapped the Run and Stop buttons in another div (for the tooltip), there were cosmetic issues on mobile devices.
2023-04-13 22:09:52 +02:00
Sebastian Serth
a7cd85507e Reduce SQL queries in the exercise controller
Fixes CODEOCEAN-JK
2023-03-14 20:58:21 +01:00
Sebastian Serth
d015e1536c Refactor tooltip for run button
Even though not reproducible locally, we had some errors captured through Sentry where the Tooltip was opened on the (already hidden) run button. This resulted in an error by the Bootstrap library. Most likely, the issue was caused by some race condition.

Fixes CODEOCEAN-BA
2023-03-14 19:19:06 +01:00
Sebastian Serth
a99da79550 Disable sorttable on tables without rows
Otherwise, the first element of the table body is being fetched which might result in an error for empty tables.

Fixes CODEOCEAN-JZ
2023-03-14 18:27:38 +01:00
Sebastian Serth
6c1bfb6815 Fix showSpinner for reset action 2023-02-28 11:35:17 +01:00
Sebastian Serth
ccbd74b4c7 Editor: Fix tooltip when submit is no longer possible 2023-02-28 00:53:15 +01:00
Sebastian Serth
5ed8f7c812 Remove tooltip from stop execution button 2023-02-28 00:52:02 +01:00
Sebastian Serth
18e48d9f45 Editor: Fix tooltip on RfC button 2023-02-28 00:52:02 +01:00
Sebastian Serth
df666b4389 Fix missing whitespace for exercise feedback page 2022-12-05 18:21:44 +01:00
Sebastian Serth
f17718f69f CSP: Extract JavaScript from layout to assets
Fixes CODEOCEAN-CP
2022-11-16 19:47:58 +01:00
Sebastian Serth
26433aa2ff Remove duplicated username (log statement) 2022-11-02 14:09:42 +01:00
Sebastian Serth
4f0b8c3c42 Reduce usage of @current_user (use helper instead) 2022-11-02 12:27:38 +01:00
Sebastian Serth
60078701f5 Editor: Allow file retrieval after code run 2022-10-29 18:49:18 +02:00
Sebastian Serth
fb9672c7a4 FileTree: Allow output as hash, convert to JSON separately 2022-10-29 18:49:18 +02:00
Karol
dba3aac800 Merge branch 'master' into refactor_proforma_import_export 2022-09-13 22:47:50 +02:00
Sebastian Serth
a2bb2844b4 Add a Content Security Policy 2022-09-06 11:20:57 +02:00
Sebastian Serth
60dc8c3b7e Apply line-based coloring for output 2022-09-02 16:56:18 +02:00
Karol
5ace779d0c fix and add specs 2022-08-31 20:51:58 +02:00
Sebastian Serth
b3f9a1ec90 Allow line breaks in feedback texts 2022-08-25 00:31:32 +02:00
Sebastian Serth
6dcccd324b Show feedback without rendering Markdown
* We do not instruct learners how to write Markdown, this might yield to an unexpected rendering
2022-08-25 00:23:08 +02:00
Karol
50b81df742 proforma upgrade and small fixes 2022-08-23 21:12:03 +02:00
Karol
3effdbe600 merge master 2022-08-20 22:20:52 +02:00
Sebastian Serth
166aa3cc6f Remove Ransack from Exercise edit for tags
* Also improve Ransack usage of attributes and associations
2022-08-20 01:33:00 +02:00
Sebastian Serth
0e96bc79c4 Conditionally show file tree 2022-08-16 23:27:39 +02:00
Sebastian Serth
f38052d235 Allow fa-spin to spin, actually
When using `display: inline;`, many browsers won't rotate the icon.
2022-08-12 18:01:47 +02:00
Sebastian Serth
4d569475c9 Fix access to external_user_statistics
Amends #1304
https://github.com/openHPI/codeocean/pull/1304
2022-08-12 17:33:45 +02:00
Sebastian Serth
8a055a0d68 Update Bootstrap from v4 to v5 2022-08-12 11:45:32 +02:00
Sebastian Serth
d223abfb5e Update from webpacker v5 to shakapacker v6.0.0.rc13
Using a two-step process is recommended:
332e25186a/docs/v6_upgrade.md
2022-08-12 10:22:55 +02:00
Sebastian Serth
b98c37ae64 Rename v4 FontAwesome icons to match v5/v6 name
While FontAwesome provides aliases for all icons, we switch to the new names for consistency. See all changes at:
https://fontawesome.com/docs/web/setup/upgrade/upgrade-from-v4#icons-renamed-since-version-4
2022-08-09 14:17:32 +02:00
Sebastian Serth
d93e71dc28 Rename v5 FontAwesome icons to match v6 name
While FontAwesome provides aliases for all icons, we switch to the new names for consistency. See all changes at:
https://fontawesome.com/docs/web/setup/upgrade/whats-changed#icons-renamed-in-version-6
2022-08-09 14:17:32 +02:00
Sebastian Serth
d4c567c722 Remove @submissions variable for external_user_statistics 2022-07-22 13:19:22 +02:00
Janis4411
66d9a2b22a added logic to hide the show/hide autosaves feature for users without permission to view detailed_statistics 2022-07-20 17:18:36 +02:00
Janis4411
a83bff80ed added a button to toggle autosave submissions as well as a label to indicate current toggle status 2022-07-20 17:18:36 +02:00
Sebastian Serth
4ef7da839d Use TestrunMessages instead of Testrun.output when displaying output 2022-04-29 22:44:35 +02:00
Sebastian Serth
19bd742bc9 Show a localized message if the program was killed.
* This will most likely happen by the OOM killer, thus we inform the user about the memory restriction.
2022-04-15 21:29:55 +02:00
Sebastian Serth
9d9570b26b Update intervention locale and add explanation 2022-04-15 14:23:05 +02:00
Sebastian Serth
2f86b18fd6 Fix run and score statistics for internal and external users 2022-01-21 13:13:52 +01:00
Sebastian Serth
ba11adb966 Fix working time statistics for internal and external users 2022-01-20 23:41:32 +01:00
Karol
c5c47715b3 Merge branch 'master' into refactor_proforma_import_export
# Conflicts:
#	spec/controllers/exercises_controller_spec.rb
2022-01-11 22:20:18 +01:00
Karol
3260d8f82f tiny refactor from exercise_found to task_found 2022-01-11 22:17:09 +01:00
Sebastian Serth
0c1a10959c Use file name with file path as identifier 2021-12-15 00:52:31 +01:00
Sebastian Serth
da4e10b990 Add CommunitySolution
* Also slightly refactor some JS files
2021-11-23 01:38:31 +01:00
Sebastian Serth
9079a0b15a Implement Tips Intervention 2021-11-23 01:38:10 +01:00
Sebastian Serth
21185ea4b3 Make empty submissions not clickable 2021-11-16 13:32:51 +01:00
Sebastian Serth
571be87879 Fix range slider for external user statistics 2021-11-16 12:02:52 +01:00
Sebastian Serth
f15bbe2c29 Fix links for external user statistics 2021-11-16 11:57:43 +01:00
Sebastian Serth
aa49731e49 Remove submissions without visible files from statistic view 2021-11-16 11:43:23 +01:00
Sebastian Serth
e224e41564 Exercise view: Re-use @execution_environments 2021-11-08 22:39:10 +01:00