Commit Graph

857 Commits

Author SHA1 Message Date
Sebastian Serth
17ac339935 Fix flickering of run/stop button during page load 2023-07-25 22:12:15 +02:00
Sebastian Serth
b6b75cee0e Improve SQL query for exercise statistics
Removing the call to distinct dramatically improves the page load time. I don't know why, but since we are only using the users to filter the submission, it's not harmful to omit it.
2023-05-12 07:52:56 +02:00
Sebastian Serth
83e7eb3ce6 Hide exercise statistics for empty user group
Fixes ODEOCEAN-M5
2023-04-14 14:27:27 +02:00
Sebastian Serth
d90cdcf80e Enlarge Run and Stop buttons again
After the recent change where we wrapped the Run and Stop buttons in another div (for the tooltip), there were cosmetic issues on mobile devices.
2023-04-13 22:09:52 +02:00
Sebastian Serth
a7cd85507e Reduce SQL queries in the exercise controller
Fixes CODEOCEAN-JK
2023-03-14 20:58:21 +01:00
Sebastian Serth
236d4d59f2 Fix typo on view for error templates 2023-03-14 19:57:20 +01:00
Sebastian Serth
d015e1536c Refactor tooltip for run button
Even though not reproducible locally, we had some errors captured through Sentry where the Tooltip was opened on the (already hidden) run button. This resulted in an error by the Bootstrap library. Most likely, the issue was caused by some race condition.

Fixes CODEOCEAN-BA
2023-03-14 19:19:06 +01:00
Sebastian Serth
a99da79550 Disable sorttable on tables without rows
Otherwise, the first element of the table body is being fetched which might result in an error for empty tables.

Fixes CODEOCEAN-JZ
2023-03-14 18:27:38 +01:00
Sebastian Serth
1c5eb09138 Safely join new parameters when switching the language
Fixes CODEOCEAN-JY
2023-03-14 16:36:29 +01:00
Sebastian Serth
6c1bfb6815 Fix showSpinner for reset action 2023-02-28 11:35:17 +01:00
Sebastian Serth
ccbd74b4c7 Editor: Fix tooltip when submit is no longer possible 2023-02-28 00:53:15 +01:00
Sebastian Serth
5ed8f7c812 Remove tooltip from stop execution button 2023-02-28 00:52:02 +01:00
Sebastian Serth
18e48d9f45 Editor: Fix tooltip on RfC button 2023-02-28 00:52:02 +01:00
Sebastian Serth
5c98ec74f0 Add legal links to Help modal 2023-02-24 19:55:23 +01:00
Sebastian Serth
f232ff634b Fix help modal not opening
The changed data attribute is required since updating to Bootstrap v5
2023-02-24 19:55:23 +01:00
Sebastian Serth
d0717fb178 Reduce SQL queries for RfC index actions
By using includes and carefully selecting objects through references, all required objects are only queried once.
2023-02-20 23:47:06 +01:00
Sebastian Serth
9c3392b324 Add consumer-based RfC Visibility settings
This setting will be useful to increase data protection, where users might not be allowed to see RfCs from other contexts.
2023-02-20 23:47:06 +01:00
Sebastian Serth
99372464aa Lock "sudo" switch for shell with root environments 2023-02-11 00:44:47 +01:00
Sebastian Serth
2679f5fa56 Allow random selection for ProxyExercise 2023-01-20 21:02:20 +01:00
Sebastian Serth
df666b4389 Fix missing whitespace for exercise feedback page 2022-12-05 18:21:44 +01:00
Sebastian Serth
ffe96d9223 Remove I18n.translation_present? monkey patch 2022-12-04 15:03:28 +01:00
Sebastian Serth
574e99eddd Fix rubocop offenses - Requires Ruby 3.1+ 2022-11-25 11:10:06 +01:00
Sebastian Serth
f17718f69f CSP: Extract JavaScript from layout to assets
Fixes CODEOCEAN-CP
2022-11-16 19:47:58 +01:00
Sebastian Serth
a9c642a116 CSP: Extract RfC JS from view to assets
Relates to CODEOCEAN-CP
2022-11-16 19:47:58 +01:00
Sebastian Serth
26433aa2ff Remove duplicated username (log statement) 2022-11-02 14:09:42 +01:00
Sebastian Serth
4f0b8c3c42 Reduce usage of @current_user (use helper instead) 2022-11-02 12:27:38 +01:00
Sebastian Serth
58548555a5 Shell: Add file system browser to retrieve arbitrary files 2022-10-29 18:49:18 +02:00
Sebastian Serth
60078701f5 Editor: Allow file retrieval after code run 2022-10-29 18:49:18 +02:00
Sebastian Serth
fb9672c7a4 FileTree: Allow output as hash, convert to JSON separately 2022-10-29 18:49:18 +02:00
Sebastian Serth
cc3739322f Always show sign-out button profile for internal users 2022-10-27 17:06:19 +02:00
Sebastian Serth
dd1f4b0ac8 Merge pull request #939 from openHPI/refactor_proforma_import_export
Refactor Proforma Import/Export
2022-10-26 17:58:48 +02:00
Sebastian Serth
b3284bb7c7 Remove unused score pill from feedback and community solution 2022-10-13 19:56:32 +02:00
Sebastian Serth
e9a00353ab Fix: Allow admins to list internal users 2022-10-11 20:21:38 +02:00
Sebastian Serth
f53c6cb3ee Shell: Add toggle to execute command as root 2022-10-04 16:06:58 +02:00
Sebastian Serth
0b374491ac Link to protected_upload_path in file render 2022-09-28 11:06:15 +02:00
Sebastian Serth
eb188dcd71 Add privilegedExecution flag to database and Poseidon Strategy 2022-09-24 22:32:41 +02:00
Sebastian Serth
16c00ec136 Add support for signed URLs used by the render_file function 2022-09-23 21:35:22 +02:00
Sebastian Serth
0e7c38657f Allow teachers to access internal users and manage them in their study groups 2022-09-22 19:24:26 +02:00
Sebastian Serth
ac3dc8d30f Allow platform admins and internal users to switch their current study group 2022-09-22 19:24:26 +02:00
Janis Vaneylen
2e3480a068 Display study_groups in the show view of internal and external users 2022-09-22 19:24:26 +02:00
Sebastian Serth
4d2fe22daf Allow assignment of study groups for internal users 2022-09-22 19:24:26 +02:00
Janis Vaneylen
998a12e6bc Adjust filter for platform_admin user search and update views 2022-09-22 19:24:26 +02:00
Sebastian Serth
664110f8f1 Show all study groups per consumer 2022-09-22 19:24:26 +02:00
Sebastian Serth
3869785ddd User: Allow removing the consumer filter 2022-09-22 19:24:26 +02:00
Karol
dba3aac800 Merge branch 'master' into refactor_proforma_import_export 2022-09-13 22:47:50 +02:00
Sebastian Serth
9e08f3a6a8 Enable Subresource Integrity 2022-09-06 11:21:37 +02:00
Sebastian Serth
a2bb2844b4 Add a Content Security Policy 2022-09-06 11:20:57 +02:00
Sebastian Serth
1581d658ea Simplify user search for external teachers 2022-09-04 19:03:15 +02:00
Sebastian Serth
b67daedfc9 Remove dead code from ProxyExercise 2022-09-04 00:05:38 +02:00
Sebastian Serth
60dc8c3b7e Apply line-based coloring for output 2022-09-02 16:56:18 +02:00