some readability improvement of score checks

This commit is contained in:
Ralf Teusner
2015-04-23 16:29:34 +02:00
parent 78f8833eb2
commit 6ecaa559fb

View File

@ -38,7 +38,7 @@ class Submission < ActiveRecord::Base
end
def normalized_score
if score && exercise.maximum_score && exercise.maximum_score > 0
if !score.nil? && !exercise.maximum_score.nil? && (exercise.maximum_score > 0)
score / exercise.maximum_score
else
0